Closed jnewb1 closed 11 months ago
As mentioned in #423, I'd rather fix any-glob-to-all-files
with these new semantics, since I'm pretty sure its current implementation is inadvertently implemented incorrectly. The old semantics are really one-glob-to-all-files
but we don't need a special function to do that.
this would be extremely helpful in our repo to get this merged!
@MaksimZhukov
who do I ask for a review to get this merged?
checkout the discussion at https://github.com/actions/labeler/issues/423
there is currently no way to apply the "CI" label with the following rule
any-glob-all-files: [Jenkinsfile, .github/**]
when a PR which changes both Jenkinsfile and github actions files
essentially, this test fails, which to me makes "any glob matches all files" extremely confusing.
perhaps this behavior should be moved to another rule, since it also breaks this potential use case: https://github.com/actions/labeler/blob/8558fd74291d67161a8a78ce36a881fa63b766a9/__tests__/changedFiles.test.ts#L228C3-L239C6