actions / languageservices

Language services for GitHub Actions workflows and expressions.
MIT License
74 stars 25 forks source link

Pull request activity type missing `(de)milestoned` #51

Open flying-sheep opened 1 year ago

flying-sheep commented 1 year ago

Describe the bug Valid pull request event types include milestoned and demilestoned (like issue event types), but the schema doesn’t show them:

https://github.com/actions/languageservices/blob/4ddbbc9db714ac2a0f39c44315426fac245e96a9/workflow-parser/src/workflow-v1.0.json#L821-L841

To Reproduce Steps to reproduce the behavior:

  1. Try to validate your valid workflow (it runs as expected when adding or removing a milestone)
  2. see validation errors for the milestoned and demilestoned event

Expected behavior milestoned and demilestoned are accepted as valid

Screenshots grafik

Package/Area

Package Version v0.3.6

Additional context The GitHub docs are also inconsistent here: The webhook docs list those event types but the workflow syntax docs don’t.

A said: It’s definitely valid. Using the event types works, part of the docs mention the event types, and clearly adding milestones to a PR is something you can do both with the API and the web UI.