Closed nikola-jokic closed 9 months ago
@nikola-jokic : does this cover the same as described in #117?
Hey @timmjd,
Yes! Your solution helped fix one problem in case the quotes are broken. This is the problem I was fixing for docker, I just extended it to be the same for k8s. Thank you for raising it, by the way! Would you mind testing it to make sure it works?
Awesome!
This implementation is even better than #117 due to you keep the array consistency.
name: Build MKDocs
runs:
using: docker
image: docker://squidfunk/mkdocs-material:latest
entrypoint: mkdocs
args:
- build --verbose --strict
spec:
containers:
- command:
- mkdocs
args:
- build --verbose --strict
name: Build MKDocs
runs:
using: docker
image: docker://squidfunk/mkdocs-material:latest
entrypoint: mkdocs
args:
- build
- --verbose
- --strict
spec:
containers:
- command:
- mkdocs
args:
- build
- --verbose
- --strict
When runner passes arguments to the hook, there may be situations where quoted strings are interpreted as separate arguments.
This PR addresses the issue and fixes the arguments based on
shlex
expansionFixes the issue in this discussion