Hi, coming back to this topic as I wanted to use a bespoke DOCKER_HOST socket in my self-hosted runner. It seems like the default code hard codes /var/run/docker.sock and I wanted to try and change that behaviour. I played with this a while back in https://github.com/actions/runner-container-hooks/issues/39.
A first observation is that using the index.js from this repo seems to change the workflow order. The dockerfile action is not built beforehand - is this expected behaviour?
Without the docker container hooks (default):
Using index.js from this repo (0.5.0)....
The main issue is that the introduction of the container hooks seems to wipe out the forward proxy settings that are configured for the container. I could put these values in the runner env file but I prefer to pass them dynamically via override values to the helm gha-runner-scale-set:
set {
name = "template.spec.containers[0].env[0].name"
value = "HTTPS_PROXY"
}
set {
name = "template.spec.containers[0].env[0].value"
value = "http://squid-service.${var.forwardproxy_namespace}:3128"
}
set {
name = "template.spec.containers[0].env[1].name"
value = "HTTP_PROXY"
}
set {
name = "template.spec.containers[0].env[1].value"
value = "http://squid-service.${var.forwardproxy_namespace}:3128"
}
Hi, coming back to this topic as I wanted to use a bespoke DOCKER_HOST socket in my self-hosted runner. It seems like the default code hard codes /var/run/docker.sock and I wanted to try and change that behaviour. I played with this a while back in https://github.com/actions/runner-container-hooks/issues/39.
My env file is as follows....
A first observation is that using the index.js from this repo seems to change the workflow order. The dockerfile action is not built beforehand - is this expected behaviour?
Without the docker container hooks (default):![image](https://github.com/actions/runner-container-hooks/assets/31928700/64597e3b-de1d-4f32-bdb9-ada66be8fe4f)
Using index.js from this repo (0.5.0)....![image](https://github.com/actions/runner-container-hooks/assets/31928700/57b4cf1e-e26d-408e-8d8e-1f19937e83b3)
The main issue is that the introduction of the container hooks seems to wipe out the forward proxy settings that are configured for the container. I could put these values in the runner env file but I prefer to pass them dynamically via override values to the helm gha-runner-scale-set:
Any suggestions welcome thankyou!