search

actions / runner-container-hooks

Runner Container Hooks for GitHub Actions
MIT License
63 stars 41 forks source link

Use ACTIONS_RUNNER_CONTAINER_HOOK_TEMPLATE to extend service containers #134

Closed katarzynainit closed 4 months ago

katarzynainit commented 5 months ago

Related to discussion under: https://github.com/actions/runner-container-hooks/issues/132

@nikola-jokic not sure how to upgrade ADR (what is your process) - awaiting your recommendation

nikola-jokic commented 4 months ago

What I would suggest for the ADR is to follow the same practice we are doing in actions runner controller. To do that, you should create a new file, with the name: ADR [Number of the PR]: Hook extensions. We should probably change the numbering, but this is currently how we are doing it in the hook. Then, mark the previous file as Superceded and add the footnote referencing your new ADR. Then, update the information in the ADR and that is it :smile:

katarzynainit commented 4 months ago

What I would suggest for the ADR is to follow the same practice we are doing in actions runner controller. To do that, you should create a new file, with the name: ADR [Number of the PR]: Hook extensions. We should probably change the numbering, but this is currently how we are doing it in the hook. Then, mark the previous file as Superceded and add the footnote referencing your new ADR. Then, update the information in the ADR and that is it 😄

Thanks, created https://github.com/actions/runner-container-hooks/pull/136