search

actions / runner-container-hooks

Runner Container Hooks for GitHub Actions
MIT License
76 stars 46 forks source link

K8s jobs and private registries #24

Closed robmaxwellirl closed 2 years ago

robmaxwellirl commented 2 years ago

Hello,

I've recently updated to ARC v0.25.x and it's supported use of container registries as jobs within it. I had posted the query initially within the ARC discussions, but believe it to be an issue with the k8s hooks that are a part of the container build for the latest release.

When testing with the private repository, I do not see a secret created in the same space as the runner is set, and the workflow job ends up in an Image pull error loop.

Looking at the source code it looks as though it should create an imageSecret to be used for the pull from the private registry but this fails to work.

I'm not too familiar with the typescript language, so not sure how to troubleshoot it, but happy to with some guidance. I've tried to populate a registry component in the action YAML, but this fails to run as it's not valid YAML in various places.

The runner prepare-job.json file suggests that it's expecting registry elements, but can't get past the action YAML validation with it.

Any help appreciated.

nikola-jokic commented 2 years ago

Hi @robmaxwellirl,

Thank you for reporting it! I will try to reproduce this issue and get back to you as soon as I can