Remove command for service containers and use service options as args

actions / runner-container-hooks

Runner Container Hooks for GitHub Actions

MIT License

76 stars 46 forks source link

Remove command for service containers and use service options as args #51

Closed claveaur closed 1 year ago

claveaur commented 1 year ago

Hi team,

First of all I'm not developer, I got more infra background, so sorry if it's not perfect as-is.

To continue on #45, I still had my services not start cause of empty command in the k8s container definition. I then patch the code and deploy it on a test environnement and got it working.

I then give you my proposal of the fix/feature improvement, but I didn't figured out how to implement the test that check everything ok, if need from your point of view.

nikola-jokic commented 1 year ago

Hey @claveaur,

Thank you for submitting this PR! Since the PR https://github.com/actions/runner-container-hooks/pull/53 is fixing this issue and the naming issue as well, I will close this one :relaxed: Thank you anyway for taking the time and implementing the fix!