Closed nielstenboom closed 1 year ago
Thanks for the review @nikola-jokic ! I've implemented your suggestions 👍
Can you please fix the linter issue
Should be fixed now after merging main into this branch 👍
It was caused by an outdated package-lock.json
Hi me again 😄
We ran into two bugs using the k8s hooks with a service, the bugs were as follows:
/
being in the container name.entrypoint: [undefined]
as the service spec, which Kubernetes would transform into[""]
and that causes an error. This was not caught by the test because the actual args passed actually containedentrypoint: null
. I've added that to the example.Please let me know what you think!