search

actions / runner-container-hooks

Runner Container Hooks for GitHub Actions
MIT License
67 stars 43 forks source link

Implement yaml extensions overwriting the default pod/container spec #75

Closed nikola-jokic closed 11 months ago

nikola-jokic commented 1 year ago

Implements ADR

fhammerl commented 1 year ago

When running docker hooks with {...} options, or k8s hooks with a string options, options is ignored as it cannot be parsed. Write to logs when options is ignored.

cjreyn commented 1 year ago

Hi. Is there any ETA for this PR to be merged? We're eagerly awaiting it as I understand it will allow us to request K8s resources such as GPUs for the build jobs.

cjreyn commented 11 months ago

A huge thanks for your work on this! We plan on using it for a build farm at Diamond Light Source (the UK's national synchrotron). So you are directly helping us with valuable scientific research into batteries, drugs for cancer, and materials science for renewables.

nikola-jokic commented 11 months ago

Hey @cjreyn,

Sorry that we did not respond earlier! Thank you for using the container hook and having interest in it! We are glad if it helps you with your work!

nielstenboom commented 11 months ago

Happy to see this merged! Seems you went with the template file after all 😉

I'll close my PR here: https://github.com/actions/runner-container-hooks/pull/50

Are there also plans for integrating this change in the actions-runner-controller downstream? We internally would love to move away from our current complex fork 😄