search

actions / runner-images

GitHub Actions runner images
MIT License
9.82k stars 3.01k forks source link

Firefox WebDriver not working on Ubuntu 24.04 #10374

Open torokati44 opened 1 month ago

torokati44 commented 1 month ago

Description

When running browser tests in Firefox, I'm getting this error: [1-0] 2024-07-31T09:44:30.951Z WARN webdriver: Request failed with status 500 due to Expected browser binary location, but unable to find binary in default location, no 'moz:firefoxOptions.binary' capability provided, and no binary flag set on the command line

Platforms affected

Runner images affected

Image version and build link

Runner Image Image: ubuntu-24.04 Version: 20240721.1.0

https://github.com/ruffle-rs/ruffle/actions/runs/10177828674/job/28150157900?pr=16352#step:11:90

Is it regression?

yes, it works on Ubuntu 22.04

Expected behavior

The tests pass.

Actual behavior

The tests don't pass.

Repro steps

Trigger a CI run of https://github.com/ruffle-rs/ruffle/pull/16352.

danielhjacobs commented 1 month ago

Ubuntu 24.04 is missing Firefox, Geckodriver, Edge, and Edgedriver: https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2404-Readme.md#browsers-and-drivers. Ubuntu 22.04 has those: https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2204-Readme.md#browsers-and-drivers.

torokati44 commented 1 month ago

I see. Well then, that's the bug.

danielhjacobs commented 1 month ago

This is in the Ubuntu 22.04 image template:

https://github.com/actions/runner-images/blob/da684ca6d2b6de512a4dec746c7c134d2b010626/images/ubuntu/templates/ubuntu-22.04.pkr.hcl#L292-L295

Both the Firefox and Edge installation lines are missing from the Ubuntu 24.04 image template:

https://github.com/actions/runner-images/blob/da684ca6d2b6de512a4dec746c7c134d2b010626/images/ubuntu/templates/ubuntu-24.04.pkr.hcl#L290-L291

torokati44 commented 1 month ago

Frankly, I don't give much of a heck about Edge, but Firefox must not be allowed to be left out, once this image is GA.

ijunaidm commented 1 month ago

@torokati44 - Thank you for bringing this issue to us, we are looking into this issue and get back to you after our findings.

torokati44 commented 1 month ago

The relevant downstream PR is now: https://github.com/ruffle-rs/ruffle/pull/17341

janbrasna commented 1 month ago

For now this is expected as the preinstalled software list mentions the browsers' removal, however according to:

"… there will definitely be changes until GA including the software list installation (for instance we are to add firefox & edge, but a bit later), but we do not guarantee we are to address all the requests…" — posted by @mikhailkoliada in https://github.com/actions/runner-images/issues/9848#issuecomment-2112088377

they plan to bring these back before it goes out of beta, so we'll see.