search

actions / runner-images

GitHub Actions runner images
MIT License
10.12k stars 3.05k forks source link

Update Visual Studio 2022 to 17.11 #10448

Closed Sergio0694 closed 2 months ago

Sergio0694 commented 2 months ago

Tool name

Visual Studio 2022

Tool license

https://visualstudio.microsoft.com/license-terms/vs2022-ga-proenterprise/

Add or update?

Desired version

17.11 (https://visualstudio.microsoft.com/en/downloads/)

Brief description of tool

This is the latest stable release of VS2022, which includes Roslyn 4.11 (needed to test new source generators).

Platforms where you need the tool

Runner images where you need the tool

hemanthmanga commented 2 months ago

@Sergio0694 Thank you for bringing this issue to our attention. We will look into this issue and will update you on this issue after investigating.

hemanthmanga commented 2 months ago

Hi @Sergio0694 , The updated version of Visual Studio 2022 is now available in the latest image deployment.The issue has been successfully resolved, Thank You.

jdblischak commented 2 months ago

The updated version of Visual Studio 2022 is now available in the latest image deployment

@hemanthmanga when is the latest image deployment going to be stabilized? The Azure windows-2022 image version has been switching back and forth this whole week (https://github.com/TileDB-Inc/conda-forge-nightly-controller/issues/133#issuecomment-2313288411).

Last night my build failed because it used image version 20240829.1.0, which has Visual Studio 17.11. This morning I restarted the build, and it is back to using image version 20240811.1.0 (Visual Studio 17.10).

From a developer experience perspective, this week has been extremely frustrating. The image version keeps fluctuating, and there is no communication to developers about when new image versions are going to deployed or rolled back (and there is no way to pin an image version in my configuration file).

Yesterday I was instructed to build against Visual Studio 17.10 for now (https://github.com/actions/runner-images/pull/10490#issuecomment-2322006844). I guess that was good advice since the image version was once again rolled back to 20240811.1.0. But it would be great if 1) you could publicly notify developers when a new image version is being deployed (eg with a GitHub Issue/PR we could subscribed to), and 2) please stop deploying new image versions and then immediately rolling them back the next day.

jdblischak commented 1 month ago

I think this Issue needs to be re-opened. Azure appears to have rolled back (yet again) to Visual Studio 17.10.

Saturday night Azure used image version 20240829.1.0 (with Visual Studio 17.11). But then Sunday night and Monday night Azure rolled back to image version 20240811.1.0 (with Visual Studio 17.10).

xref: https://github.com/TileDB-Inc/conda-forge-nightly-controller/issues/135#issuecomment-2326817208

jdblischak commented 1 month ago

I think I've discovered the pattern. My nightly Windows job consistently fails on Saturday night when a new windows-2022 image version is released, and then passes on Sunday night when the image is inevitably rolled back to 20240811.1.0 (https://github.com/TileDB-Inc/conda-forge-nightly-controller/issues/137#issuecomment-2338274752). So apparently Visual Studio 17.11 is currently only available on Saturdays.

jdblischak commented 1 month ago

2 weeks after this Issue was closed, it appears that the Azure windows-2022 image has finally been migrated to Visual Studio 17.11. The image version 20240912.1.0 has been live for a couple of days now. Please don't roll it back!

And please consider providing some sort of mechanism for developers to track image version updates/rollbacks. It's hard to maintain CI pipelines when the image version randomly changes.