actions / runner-images

GitHub Actions runner images
MIT License
10.22k stars 3.08k forks source link

windows-2022 version 20241113.3.0 breaks our build #10987

Open Bouke opened 5 days ago

Bouke commented 5 days ago

Description

We're using repeatable package restores in our .NET build pipeline. However as version 20241113.3.0 started rolling out to agents, our build has been failing:

error NU1004: The project's runtime identifiers have changed from. Project's runtime identifiers: win-x86, lock file's runtime identifiers win7-x86.The packages lock file is inconsistent with the project dependencies so restore can't be run in locked mode. Disable the RestoreLockedMode MSBuild property or pass an explicit --force-evaluate option to run restore to update the lock file.

We're still targeting .NET 8, not .NET 9, so I don't understand why this is now failing. We've since tried updating the lockfiles. However as some agents are still running 20241021.1.0, the updated lockfiles will fail on those. This is not a great situation to be in. Also updating the lockfiles requires all our developers to install .NET 9 SDK, which is something we would like to avoid.

Platforms affected

Runner images affected

Image version and build link

20241113.3.0

Is it regression?

20241021.1.0

Expected behavior

Projects targeting .NET 8 (LTS) should continue to do so.

Actual behavior

Build fails.

Repro steps

-

vidyasagarnimmagaddi commented 5 days ago

Hi @Bouke , Thank you for bringing this issue. we will revert once we have an update. thanks

Bouke commented 5 days ago

Hi @vidyasagarnimmagaddi, any update on this?

vidyasagarnimmagaddi commented 4 days ago

Hi @Bouke ,We observed that some agents are running with 20241021.1.0 We plan to start image rollout this week,once this is done, issue will be resolved.

Bouke commented 4 days ago

@vidyasagarnimmagaddi What do you mean with this, will you revert the rollout of 20241113.3.0?

vidyasagarnimmagaddi commented 4 days ago

@vidyasagarnimmagaddi What do you mean with this, will you revert the rollout of 20241113.3.0?

Hi @Bouke , i mean new image rollout .

Bouke commented 4 days ago

@vidyasagarnimmagaddi Can you be more specific in how you're going to address this issue? For example: "we're going to complete the 20241113.3.0 image rollout, and you'll not see 20241021.1.0 again". If that's the case: that doesn't solve the issue: we'd still need all our developers to install .NET 9 SDK.

vidyasagarnimmagaddi commented 4 days ago

Hi @Bouke , When we rollout new image version this week, there will not be any agents with older version i.e, (20241021.1.0, 20241113.3.0) ,. We make sure all the agents are with the newly released version only. thanks.

Bouke commented 4 days ago

Please consider rolling back .NET 9 SDK. There's a known issue with .NET 9 that silently breaks our app in production, which is not going to be fixed until .NET 10 SDK: https://github.com/dotnet/sdk/pull/44160#issuecomment-2485805964.

normeno commented 4 days ago

I have a similar problem. I use MSBuild and with version 20241021.1.0 it works, but with version 20241113.3.0, my workflow breaks

20241021.1.0: image

20241113.3.0: image

Unfortunately that version is not something I can select and I don't know how to fix it.

Bouke commented 1 day ago

@vidyasagarnimmagaddi did you read anything of what I posted?

vidyasagarnimmagaddi commented 1 day ago

Please consider rolling back .NET 9 SDK. There's a known issue with .NET 9 that silently breaks our app in production, which is not going to be fixed until .NET 10 SDK: dotnet/sdk#44160 (comment).

Hi @Bouke , we are currently anayzing and will revert you . thanks