actions / runner-images

GitHub Actions runner images
MIT License
10.15k stars 3.06k forks source link

Add TypeScript #1218

Closed violet-devsec closed 4 years ago

violet-devsec commented 4 years ago

Tool information

Area for Triage: Scripting and command line

Question, Bug, or Feature?: Feature

Virtual environments affected

Can this tool be installed during the build?

Tool installation time in runtime

Are you willing to submit a PR?

maxim-lobanov commented 4 years ago

Hello, we already installing TypeScript on Windows images but don't publish it in documentation since it is just NPM package: https://github.com/actions/virtual-environments/blob/master/images/win/scripts/Installers/Install-TypeScript.ps1

Btw, what is the use case to have TypeScript pre-installed? It is pretty small NPM package that usually included to package.json and downloaded during npm install. Pre-installing TypeScript on image is some kind of pre-caching but we cache the single version and package.json can point to different one.

violet-devsec commented 4 years ago

Thanks for the info @maxim-lobanov. I have solved my issue by adding TypeScript to package.json.

I had an issue with TypeScript version. But I was not sure whether TyepScript pre-installed or package.json making the issue.