actions / runner-images

GitHub Actions runner images
MIT License
10.1k stars 3.04k forks source link

SwiftFormat removed from macOS 12 #5494

Closed bdrelling closed 2 years ago

bdrelling commented 2 years ago

Description

SwiftFormat 0.49.7 is on the macos-11 runner: https://github.com/actions/virtual-environments/blob/main/images/macos/macos-11-Readme.md#tools

But it's missing from the macos-12 runner: https://github.com/actions/virtual-environments/blob/main/images/macos/macos-12-Readme.md#tools

  1. Why was it removed? I can't find any news or information on this.
  2. Can it be added back? SwiftFormat is an extremely widespread tool. If macos-12 includes SwiftLint, it should probably also include SwiftFormat.

Virtual environments affected

Image version and build link

n/a

Is it regression?

Yes, macos-11 included SwiftFormat.

Expected behavior

SwiftFormat is included.

Actual behavior

SwiftFormat is not included.

Repro steps

Attempt to run SwiftFormat on macos-12.

al-cheb commented 2 years ago

Hey @bdrelling, We will pre-install SwiftFormat on macOS-12.

bdrelling commented 2 years ago

@al-cheb Incredibly quick response, really appreciate it!

I'm not sure how to keep up with changes to the runners, do you know when/how this would be added to the image?

In the meantime, it is simple enough to add a brew install swiftformat step for now, so this isn't urgent, just inconvenient.

Thanks again!

al-cheb commented 2 years ago

The new image has been deployed with swiftformat on board.