actions / runner-images

GitHub Actions runner images
MIT License
9.17k stars 2.84k forks source link

[Linux, macOS, Windows] Download two prior CodeQL bundles #6884

Closed angelapwen closed 1 year ago

angelapwen commented 1 year ago

Description

Previously, our runner image only included the most recent release of CodeQL. In order to improve stability of rollout of new CodeQL versions, we are now downloading the most recent two releases.

The change updates the Linux and Windows script variable names to match that of the Mac script, because they are mostly functionally identical. It also adds the same log messages to all scripts and ensures Mac and Windows test parity. It tests that there are two bundles in each of the OS's as well.

This will approximately double the total size and installation time of the existing CodeQL tool.

Related issue:

Check list

angelapwen commented 1 year ago

@mikhailkoliada do you mind taking another look when you have time?

I plan on cleaning up the commits before merge, but didn't want to rebase yet for ease of review. Please let me know if you prefer I clean them up sooner!

henrymercer commented 1 year ago

@mikhailkoliada We've released the changes to default.json in v2 of the CodeQL Action, so https://raw.githubusercontent.com/github/codeql-action/v2/src/defaults.json now has all the required properties. Please could you kick off the tests so we can see if the runner images are successfully created? I don't think any of us have permission to do that. Thanks!

angelapwen commented 1 year ago

@mikhailkoliada I've addressed your comments; could you run the CI builds when you have time? Thank you ✨

henrymercer commented 1 year ago

For more context, we'd like to get this change in before the next runner image update cycle starts if possible as part of our work on controlled rollout of the CodeQL Action (see backlinked issue for more information).

mikhailkoliada commented 1 year ago

/azp run ubuntu2204,macos12,windows2022

azure-pipelines[bot] commented 1 year ago
Azure Pipelines successfully started running 3 pipeline(s).
angelapwen commented 1 year ago

Thank you @mikhailkoliada !! Thanks to @adityasharad's help I found a bug and have pushed up the fix. Do you mind re-running the workflows?

Also, it looks like the MacOS run failed separately because I'm not on the allowlist for contributors. Could you add me to it?

azure-pipelines[bot] commented 1 year ago
Azure Pipelines successfully started running 1 pipeline(s).
mikhailkoliada commented 1 year ago

/azp run ubuntu2204,windows2019

azure-pipelines[bot] commented 1 year ago
Azure Pipelines successfully started running 2 pipeline(s).
AlenaSviridenko commented 1 year ago

/azp run ubuntu2204,windows2019

azure-pipelines[bot] commented 1 year ago
Azure Pipelines successfully started running 2 pipeline(s).
angelapwen commented 1 year ago

/azp run ubuntu2204,macos12,windows2022

azure-pipelines[bot] commented 1 year ago
Azure Pipelines successfully started running 3 pipeline(s).
angelapwen commented 1 year ago

/azp run ubuntu2204,windows2019

azure-pipelines[bot] commented 1 year ago
Azure Pipelines successfully started running 2 pipeline(s).
angelapwen commented 1 year ago

/azp run ubuntu2204,windows2019

azure-pipelines[bot] commented 1 year ago
Azure Pipelines successfully started running 2 pipeline(s).
angelapwen commented 1 year ago

/azp run ubuntu2204,windows2019

azure-pipelines[bot] commented 1 year ago
Azure Pipelines successfully started running 2 pipeline(s).
angelapwen commented 1 year ago

Upstream Actions failure. Will re-run later

angelapwen commented 1 year ago

/azp run ubuntu2204,windows2019

angelapwen commented 1 year ago

/azp run ubuntu2204,windows2019

azure-pipelines[bot] commented 1 year ago
Azure Pipelines successfully started running 2 pipeline(s).
angelapwen commented 1 year ago

/azp run ubuntu2204,windows2019

azure-pipelines[bot] commented 1 year ago
Azure Pipelines successfully started running 2 pipeline(s).
angelapwen commented 1 year ago

/azp run ubuntu2204,windows2019

azure-pipelines[bot] commented 1 year ago
Azure Pipelines successfully started running 2 pipeline(s).
angelapwen commented 1 year ago

/azp run ubuntu2204,windows2019

azure-pipelines[bot] commented 1 year ago
Azure Pipelines successfully started running 2 pipeline(s).
angelapwen commented 1 year ago

/azp run macos12,windows2022

azure-pipelines[bot] commented 1 year ago
Azure Pipelines successfully started running 2 pipeline(s).
angelapwen commented 1 year ago

/azp run macos12,windows2022

azure-pipelines[bot] commented 1 year ago
Azure Pipelines successfully started running 2 pipeline(s).
angelapwen commented 1 year ago

/azp run ubuntu2204,macos12,windows2022

azure-pipelines[bot] commented 1 year ago
Azure Pipelines successfully started running 3 pipeline(s).
angelapwen commented 1 year ago

/azp run ubuntu2204,macos12,windows2022

azure-pipelines[bot] commented 1 year ago
Azure Pipelines successfully started running 3 pipeline(s).
angelapwen commented 1 year ago

/azp run ubuntu2204,macos12,windows2022

azure-pipelines[bot] commented 1 year ago
Azure Pipelines successfully started running 3 pipeline(s).
angelapwen commented 1 year ago

/azp run ubuntu2204,macos12,windows2022

azure-pipelines[bot] commented 1 year ago
Azure Pipelines successfully started running 3 pipeline(s).
angelapwen commented 1 year ago

Sorry about the spam... tests were failing due to other changes, had to rebase on main

angelapwen commented 1 year ago

/azp run ubuntu2204,macos12,windows2022

azure-pipelines[bot] commented 1 year ago
Azure Pipelines successfully started running 3 pipeline(s).
angelapwen commented 1 year ago

/azp run ubuntu2204,macos12,windows2022

azure-pipelines[bot] commented 1 year ago
Azure Pipelines successfully started running 3 pipeline(s).
angelapwen commented 1 year ago

/azp run ubuntu2204,macos12,windows2022

azure-pipelines[bot] commented 1 year ago
Azure Pipelines successfully started running 3 pipeline(s).
angelapwen commented 1 year ago

/azp run ubuntu2204,macos12,windows2022