Closed angelapwen closed 1 year ago
@mikhailkoliada do you mind taking another look when you have time?
I plan on cleaning up the commits before merge, but didn't want to rebase yet for ease of review. Please let me know if you prefer I clean them up sooner!
@mikhailkoliada We've released the changes to default.json
in v2 of the CodeQL Action, so https://raw.githubusercontent.com/github/codeql-action/v2/src/defaults.json now has all the required properties. Please could you kick off the tests so we can see if the runner images are successfully created? I don't think any of us have permission to do that. Thanks!
@mikhailkoliada I've addressed your comments; could you run the CI builds when you have time? Thank you ✨
For more context, we'd like to get this change in before the next runner image update cycle starts if possible as part of our work on controlled rollout of the CodeQL Action (see backlinked issue for more information).
/azp run ubuntu2204,macos12,windows2022
Thank you @mikhailkoliada !! Thanks to @adityasharad's help I found a bug and have pushed up the fix. Do you mind re-running the workflows?
Also, it looks like the MacOS run failed separately because I'm not on the allowlist for contributors. Could you add me to it?
/azp run ubuntu2204,windows2019
/azp run ubuntu2204,windows2019
/azp run ubuntu2204,macos12,windows2022
/azp run ubuntu2204,windows2019
/azp run ubuntu2204,windows2019
/azp run ubuntu2204,windows2019
Upstream Actions failure. Will re-run later
/azp run ubuntu2204,windows2019
/azp run ubuntu2204,windows2019
/azp run ubuntu2204,windows2019
/azp run ubuntu2204,windows2019
/azp run ubuntu2204,windows2019
/azp run macos12,windows2022
/azp run macos12,windows2022
/azp run ubuntu2204,macos12,windows2022
/azp run ubuntu2204,macos12,windows2022
/azp run ubuntu2204,macos12,windows2022
/azp run ubuntu2204,macos12,windows2022
Sorry about the spam... tests were failing due to other changes, had to rebase on main
/azp run ubuntu2204,macos12,windows2022
/azp run ubuntu2204,macos12,windows2022
/azp run ubuntu2204,macos12,windows2022
/azp run ubuntu2204,macos12,windows2022
Description
Previously, our runner image only included the most recent release of CodeQL. In order to improve stability of rollout of new CodeQL versions, we are now downloading the most recent two releases.
The change updates the Linux and Windows script variable names to match that of the Mac script, because they are mostly functionally identical. It also adds the same log messages to all scripts and ensures Mac and Windows test parity. It tests that there are two bundles in each of the OS's as well.
This will approximately double the total size and installation time of the existing CodeQL tool.
Related issue:
Check list