search

actions / runner-images

GitHub Actions runner images
MIT License
9.17k stars 2.84k forks source link

WiX 3.14.1 causes issues due to TEMP directory handling #9667

Closed JSdeJong closed 1 month ago

JSdeJong commented 1 month ago

Description

Described in issue tracker: https://github.com/wixtoolset/issues/issues/8078

Remediation currently is to revert back to 3.14.0

Platforms affected

Runner images affected

Image version and build link

Image: windows-2022 Version: 20240322.1.0

Is it regression?

No

Expected behavior

Rollback WiX to 3.14.0 until the bug in WiX 3.14.1 is solved

Actual behavior

WiX 3.14.1 is installed, which breaks Windows Installer builds due to bug in Wix 3.14.1.

See https://github.com/wixtoolset/issues/issues/8078

Repro steps

Create a project that creates a Windows Installer file with a Custom Action Build the project via Azure Pipelines on latest Windows 2019 or Windows 2022 build agent. Run Windows Installer as user, it will return a SFXCA error in de Windows installer log file.

SFXCA: Failed to create temp directory. Error code 5 CustomAction CheckingAppIsRunning returned actual error code 1603 (note this may not be 100% accurate if translation happened inside sandbox)

When building this project with a build agent that runs WiX 3.14.0, it will build a Windows Installer file that will not return this issue

erik-bershel commented 1 month ago

Hey @JSdeJong! Thank you for bringing it to our attention. We'll think about what to do with this issue.

erik-bershel commented 1 month ago

Hi again @JSdeJong! It was decided to wait for the new version of tool to be available. Previous version had (have?) other bugs and CVE: https://github.com/actions/runner-images/issues/9543 There is no particular point in replacing some breaking changes with others. I will leave this issue to better inform users until a new update occurs.

In the meantime there is a workaround you could use, it will take about couple minutes:

choco install wixtoolset --version <desired_version> --allow-downgrade --force
birarroshan commented 1 month ago

Hello @erik-bershel Is there any ETA for newer version in image? We are waiting on production release. ETA will help us to take a informed decision before downgrade

erik-bershel commented 1 month ago

Hello @erik-bershel Is there any ETA for newer version in image? We are waiting on production release.

No ETA since it is an external issue. I suppose we'll deliver it next week after release in Chocolatey published and approved by maintainers. Till then you may use workaround.

JSdeJong commented 1 month ago

It seems the fix for WiX is committed, but not released yet. So first have to wait for WiXToolset team to release a new version with the fix @birarroshan

@erik-bershel Thanks for the very quick reply! Currently we managed to downgrade WiX in our pipelines.

erik-bershel commented 1 month ago

I planing to close this item due to the fact that in general we cannot do anything on our part to resolve it without ruining the experience of other users. As I said, the release of a new image with the fixed WIX toolset will occur next week after the updates are published in the Chocolatey repository. Until then, we ask those who are affected by the WIX bug to use the workaround.

birarroshan commented 4 weeks ago

Hello @erik-bershel, I cannot see Wix release tag 3.14.2. May I know what is the next version?

erik-bershel commented 4 weeks ago

Hey @birarroshan! It isn't yet available in Choco. See there: https://community.chocolatey.org/packages/wixtoolset#versionhistory We'll deploy it next week after the release in Chocolatey.

thenextman commented 2 weeks ago

Hi again @JSdeJong! It was decided to wait for the new version of tool to be available. Previous version had (have?) other bugs and CVE: #9543 There is no particular point in replacing some breaking changes with others. I will leave this issue to better inform users until a new update occurs.

In the meantime there is a workaround you could use, it will take about couple minutes:

choco install wixtoolset --version <desired_version> --allow-downgrade --force

Posting because I lost a bunch of time to this; but the above command won't work - I'm not sure why, but I suspect the WiX installer doesn't allow downgrades.

It's necessary to uninstall wixtoolset before installing the older version

choco uninstall wixtoolset

tve-altx commented 5 days ago

Hey @birarroshan! It isn't yet available in Choco. See there: https://community.chocolatey.org/packages/wixtoolset#versionhistory We'll deploy it next week after the release in Chocolatey.

Do you have some information about release in Chocolatey?

erik-bershel commented 4 days ago

Do you have some information about release in Chocolatey?

No, we do not have a separate communication channel with the Chocolatey support team.