actions / runner-images

GitHub Actions runner images
MIT License
9.13k stars 2.82k forks source link

Install-WindowsUpdates.ps1 is failing to install April 2024 updates #9694

Closed frede192 closed 2 weeks ago

frede192 commented 2 weeks ago

Description

Windows April 2024 security update (KB5036909) fails to install.

image

Platforms affected

Runner images affected

Image version and build link

latest version

Is it regression?

Worked before patch April 9, 2024

Expected behavior

Updates should install successfully or at least image generation should complete

Actual behavior

Updates do not install, image generation fails

Repro steps

Trigger a build and wait

MaksimZhukov commented 2 weeks ago

Hello @frede192! As you can see, Windows22 test build on the main branch was successful yesterday. Please make sure you are using the main branch and correct configuration.

frede192 commented 2 weeks ago

Hi @MaksimZhukov,

I just checked. We are using the main branch, and have followed these docs as part of setup: https://github.com/actions/runner-images/blob/main/docs/create-image-and-azure-resources.md#automated-image-generation

Our packer build command which results in a failed windows update looks as follows:

packer build -var "client_id=$ClientId" `
                -var "client_secret=$ClientSecret" `
                -var "install_password=$InstallPassword" `
                -var "location=$Location" `
                -var "subscription_id=$SubscriptionId" `
                -var "temp_resource_group_name=$TempResourceGroupName" `
                -var "tenant_id=$TenantId" `
                -var "virtual_network_name=$VirtualNetworkName" `
                -var "virtual_network_resource_group_name=$VirtualNetworkRG" `
                -var "virtual_network_subnet_name=$VirtualNetworkSubnet" `
                -var "managed_image_name=$ImageType-$ResourcesNamePrefix" `
                -var 'azure_tags={ "ExcludeMdeAutoProvisioning": "True" }' `
                -var "managed_image_resource_group_name=$ResourceGroup" `
                -color=false `
                $TemplatePath
frede192 commented 2 weeks ago

Hi again @MaksimZhukov,

I tried to re-run the pipeline (without doing any changes) and today it works.

So I do not know why 'Install-WindowsUpdates.ps1' failed yesterday when trying to install security update (KB5036909).

I will close this issue for now. If I run into this problem again in the future, then we can revisit it then.

Thank you