search

actions / runner-images

GitHub Actions runner images
MIT License
9.12k stars 2.82k forks source link

pipx home path could cause problems #9703

Open dunkmann00 opened 2 weeks ago

dunkmann00 commented 2 weeks ago

Description

Hello, the new version of pipx (1.5.0) has updated the default location for pipx managed virtual environments. The main reason for doing this was to avoid issues on macOS and Windows.

It seems the custom locations runner-images uses for the macOS arm64 runner and the windows runner have spaces in their paths. This results in this message being displayed in the log when using pipx:

Found a space in the home path. We heavily discourage this, due to multiple incompatibilities. Please check our docs for more information on this, as well as some pointers on how to migrate to a different home path.

It might be worth changing the PIPX_HOME directory for these runners.

In case it is useful, here is the pipx code that sets the default locations for the different platforms.

Thanks!

Platforms affected

Runner images affected

Image version and build link

I saw this on a job I ran on both:

Is it regression?

No, an update to pipx.

Expected behavior

No warning when using pipx.

Actual behavior

The following warning message when running pipx:

Found a space in the home path. We heavily discourage this, due to multiple incompatibilities. Please check our docs for more information on this, as well as some pointers on how to migrate to a different home path.

Repro steps

Use pipx on windows or macos Arm64.

MaksimZhukov commented 2 weeks ago

Hello @dunkmann00! Thank you for reporting the problem! We will investigate it and come back to you as soon as we have any updates