search

actions / runner-images

GitHub Actions runner images
MIT License
9.17k stars 2.84k forks source link

Update GitHub CLI to 2.49.0 in Ubuntu 22.04 (current ubuntu-latest) #9784

Closed matthewfeickert closed 1 day ago

matthewfeickert commented 2 weeks ago

Tool name

GitHub CLI

Tool license

MIT

Add or update?

Desired version

2.49.0

Approximate size

No response

Brief description of tool

No response

URL for tool's homepage

https://github.com/cli/cli

Provide a basic test case to validate the tool's functionality.

gh attestation verify --help

Platforms where you need the tool

Runner images where you need the tool

Can this tool be installed during the build?

I think so, but this wouldn't be the recommended approach.

Tool installation time in runtime

No response

Are you willing to submit a PR?

Yes, though it unclear from PRs like PR https://github.com/actions/runner-images/pull/9730 how to actually do this for the GitHub CLI.

matthewfeickert commented 2 weeks ago

In PR https://github.com/actions/runner-images/pull/9776, the ubuntu-24.04 runner environment description was added, which includes

https://github.com/actions/runner-images/blob/7bb1d84f7071bfa9c350d7552d9631d9a69bfdb0/images/ubuntu/Ubuntu2404-Readme.md?plain=1#L95

This is great, but for using gh attestation verify to validate a GitHub artifact attestation before publishing to an index or repository in a GitHub Actions workflow (c.f. https://github.com/scikit-hep/pyhf/pull/2473)

    - name: Verify wheel artifact attestation
      env:
        GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
      run: gh attestation verify dist/package-*.whl --repo ${{ github.repository }}

this now requires users to switch to ubuntu-24.04. As ubuntu-22.04 is the current ubuntu-latest runner, it would be useful to update

https://github.com/actions/runner-images/blob/7bb1d84f7071bfa9c350d7552d9631d9a69bfdb0/images/ubuntu/Ubuntu2204-Readme.md?plain=1#L118

to 2.49.0 there as well.

sssharif commented 2 weeks ago

thank you for your request. GitHub CLI will be updated in next image deployment. We expect next image deployment will be on tuesday or wednesday next week.

cclauss commented 1 week ago

https://github.com/actions/runner-images/releases

matthewfeickert commented 1 week ago

We expect next image deployment will be on tuesday or wednesday next week.

@sssharif @shamil-mubarakshin Do you have an updated estimate on this?

mikhailkoliada commented 1 day ago

Deployed

matthewfeickert commented 1 day ago

Thank you @mikhailkoliada!

For others, c.f. https://github.com/actions/runner-images/releases/tag/ubuntu22%2F20240514.2 for the full deployment notes.