search

actions / runner

The Runner for GitHub Actions :rocket:
https://github.com/features/actions
MIT License
4.9k stars 962 forks source link

Reusable workflows: Increase limit of called workflow depth from 2 to 3 or more #1797

Closed cytopia closed 2 years ago

cytopia commented 2 years ago

Describe the enhancement

I am trying to generalize my resuable workflows. By doing so I hit the maximum depth limit:

error parsing called workflow "./.github/workflows/build.yml@": 
job "arch" calls workflow "./.github/workflows/docker-multistage-build.yml@",
but doing so would exceed the limit on called workflow depth of 2

I would like to be able to allow reusable workflows to call other reusable workflows and then call the initial one in my main workflow

nikola-jokic commented 2 years ago

Hi @cytopia,

This is enhancement is not related to the runner, it concerns the GitHub actions platform more generally. Could you please post your feedback on the GitHub Community Support Forum which is actively monitored? Using the forum ensures that we route your problem to the correct team. :smiley:

Jeanstephane269 commented 2 years ago

stefreak commented 2 years ago

New limit is 4: https://github.blog/changelog/2022-08-22-github-actions-improvements-to-reusable-workflows-2/

baracudda commented 1 year ago

then why did I just now get "but doing so would exceed the limit on called workflow depth of 3"?

e3b0c442 commented 1 year ago

Because the total depth is 4, including the top level workflow, so the called workflow depth limit is 3.

That said, this really reeks of an artificial limitation or suboptimal implementation, and is extremely limiting from an encapsulation and composability perspective. I hope there are plans in progress to address whatever the root failure is and remove this limit entirely (or set it to a number that no sane workflow can reach).

hex0cter commented 1 month ago

Crap, I just hit the limit. This comes as such a surprise!