actions / runner

The Runner for GitHub Actions :rocket:
https://github.com/features/actions
MIT License
4.89k stars 959 forks source link

Unable to hide the inputs in the first step of the workflow_call job #2988

Open arununzer opened 12 months ago

arununzer commented 12 months ago

Describe the bug A clear and concise description of what the bug is.

Unable to hide the inputs in the first step of the workflow_call job

To Reproduce Steps to reproduce the behavior:

  1. Go to 'Actions tab after building a sample workflow call job - reusable workflow'
  2. Run 'the sample action'
  3. See error

Expected behavior A clear and concise description of what you expected to happen.

able to hide the inputs in the first step of the workflow_call job

Runner Version and Platform

Version of your runner? 2.311.0

OS of the machine running the runner? OSX/Windows/Linux/... ubuntu 22.04 self hosted runner

What's not working?

Please include error messages and screenshots. Screenshot (4)

Job Log Output

Runner and Worker's Diagnostic Logs

 Inputs
    CostCenter: 10000
    LegalEntity: GmbH
    Project: Infra
    Team: Platform Engineering
    env: int
    secret_name: infra/arun-test2
    secret_value: user=arun,pass=wi;hf&0(^%$!d@YLn7
arununzer commented 11 months ago

Any update on this as its quite urgent .. Thanks :)

rgrygorovych commented 9 months ago

Same issue, even using the reusable actions from marketplace not working:

`
Mask-Secrets: name: Mask secret ${{ inputs.name }} runs-on: ubuntu-latest

steps:
  - name: Hide the inputs values to keep them private in the logs when running this workflow
    uses: levibostian/action-hide-sensitive-inputs@v1
    with:
      exclude_inputs: operation, name, aws_region, environment, product

`

However, this action does the job in other cases, in not reusable workflows.

rgrygorovych commented 9 months ago

@arununzer check your password leakage secret_value: user=arun,pass=wi;h***********

;)

rgrygorovych commented 9 months ago

btw, levibostian/action-hide-sensitive-inputs is only properly working with workflow_dispatch and not workflow_call :(

tateexon commented 4 months ago

This definitely needs fixed. We have secrets that would get shown because of this. Been working around it with actions for a long time now. It just muddies the reusability across repos and opens up a lot of copy paste that can cause errors and is a lot to maintain.