actions / runner

The Runner for GitHub Actions :rocket:
https://github.com/features/actions
MIT License
4.91k stars 965 forks source link

Make Settings.IsHostedServer value consistent with UrlUtil.IsHostedServer #3326

Open alixinne opened 5 months ago

alixinne commented 5 months ago

When running GitHub Enterprise Server with a pool of JIT-configured runners (such as what philips-labs/terraform-aws-github-runner provides), #1199 still occurs. The fix in #1291 uses the "IsHostedServer" property from the settings which is not set by the GHES endpoint for JIT configuration.

This change computes the default value of IsHostedServer from the GitHub server URL, as is already done in lots of other parts of the code to make it consistent.