Open jsoref opened 2 days ago
Wow, you found another symptom of #2009.
But my PR has never got any review comment..
With my patch applied this is a successful outcome
##[debug]Evaluating condition for step: 'Post call-call-node'
##[debug]Evaluating: always()
##[debug]Evaluating always:
##[debug]=> true
##[debug]Result: true
##[debug]Starting: Post call-call-node
##[debug]Begin evaluating template
##[debug]Finished evaluating template
##[debug]Loading inputs
##[debug]Loading env
Post job cleanup.
##[debug]Evaluating condition for step: 'run'
##[debug]Evaluating: always()
##[debug]Evaluating always:
##[debug]=> true
##[debug]Result: true
##[debug]Starting: run
##[debug]Begin evaluating template
##[debug]Finished evaluating template
##[debug]Loading inputs
##[debug]Loading env
Post job cleanup.
##[debug]Evaluating condition for step: 'run'
##[debug]Evaluating: always()
##[debug]Evaluating always:
##[debug]=> true
##[debug]Result: true
##[debug]Starting: run
##[debug]Loading inputs
##[debug]Loading env
Post job cleanup.
goodbye cruel world 1
/home/ubuntu/rt/_work/turbo-octo-couscous/turbo-octo-couscous/node/post.js:3
throw "dying";
^
dying
(Use `node --trace-uncaught ...` to show where the exception was thrown)
Node.js v20.5.0
##[debug]Node Action run completed with exit code 1
##[debug]Finished: run
##[debug]Finished: run
##[debug]Finishing: Post call-call-node
self-hosted runner
ubuntu@ubuntu:~/rt/bin$ ./Runner.Listener run
√ Connected to GitHub
Current runner version: '3.0.0'
2024-10-18 09:56:45Z: Listening for Jobs
2024-10-18 09:57:15Z: Running job: call-action
2024-10-18 09:58:34Z: Job call-action completed with result: Succeeded
Describe the bug
continue-on-error
works at a workflow step level to prevent errors from a step from being fatalcontinue-on-error
works at a composite step level to prevent errors in the composite step (if it's a node step) from being fatalcontinue-on-error
doesn't prevent a composite action that calls a composite action that calls a node action from being fatalTo Reproduce Steps to reproduce the behavior:
Expected behavior The job should ✅ because the continue-on-error for the intermediate composite action should mask the failure from the inneromst nested composite action that happens to call a node action that happens to fail.
Runner Version and Platform
Version of your runner? Current runner version: '2.320.0'
OS of the machine running the runner? OSX/Windows/Linux/... Linux
What's not working?
Please include error messages and screenshots.
Job Log Output
If applicable, include the relevant part of the job / step log output here. All sensitive information should already be masked out, but please double-check before pasting here.
Runner and Worker's Diagnostic Logs
If applicable, add relevant diagnostic log information. Logs are located in the runner's
_diag
folder. The runner logs are prefixed withRunner_
and the worker logs are prefixed withWorker_
. Each job run correlates to a worker log. All sensitive information should already be masked out, but please double-check before pasting here.Runner_20241018-055434-utc.log Worker_20241018-055423-utc.log Worker_20241018-055437-utc.log
The workaround is to include
continue-on-error
one layer closer, but, it's frustrating that an outer action can't usecotinue-on-error
to continue on error.