search

actions / setup-dotnet

Set up your GitHub Actions workflow with a specific version of the .NET core sdk
MIT License
922 stars 454 forks source link

Fix glob bug in package.json scripts section #401

Closed IvanZosimov closed 1 year ago

IvanZosimov commented 1 year ago

Description: In the scope of this PR, we fix the bug related to the wrong interpretation of the glob patterns. Glob patterns that aren't wrapped by the quotes are opened and transformed into concrete paths by the shell used in the OS (e.g., PowerShell, bash. zsh, and so on). The behavior of this transformation is different for different shells, which can cause different behaviors of the tools. By wrapping glob patterns in double quotes, we prevent shell from opening and transforming them and instruct tool to do it instead.

Related issue: https://github.com/actions/runner-images-internal/issues/4899

Westleydscott commented 1 year ago

Ivan you rock. Thank you

On Tue, Mar 28, 2023, 5:04 AM Ivan @.***> wrote:

Description: In the scope of this PR, we fix the bug related to the wrong interpretation of the glob patterns. Glob patterns that aren't wrapped by the quotes are opened and transformed into concrete paths by the shell used in the OS (e.g., PowerShell, bash. zsh, and so on). The behavior of this transformation is different for different shells, which can cause different behaviors of the tools. By wrapping glob patterns in double quotes, we prevent shell from opening and transforming them and instruct tool to do it instead.

Related issue: actions/runner-images-internal#4899 https://github.com/actions/runner-images-internal/issues/4899

You can view, comment on, or merge this pull request online at:

https://github.com/actions/setup-dotnet/pull/401 Commit Summary

File Changes

(1 file https://github.com/actions/setup-dotnet/pull/401/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/actions/setup-dotnet/pull/401, or unsubscribe https://github.com/notifications/unsubscribe-auth/A5QXBGII2TLVC5ZQIS7NACTW6LHTLANCNFSM6AAAAAAWKO5SDQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>