actions / setup-dotnet

Set up your GitHub Actions workflow with a specific version of the .NET core sdk
MIT License
919 stars 454 forks source link

global.json comments #436

Closed leotsarev closed 7 months ago

leotsarev commented 1 year ago

Description: global.json allows // comments See https://learn.microsoft.com/en-us/dotnet/core/tools/global-json#globaljson-schema

Task version: 3.2.0

Platform:

Runner type:

Repro steps:
https://github.com/joinrpg/joinrpg-net/blob/e78bdc3815deb004d5438d534989656da8a06ae8/global.json

{
  "sdk": {
    "version": "7.0.304",
    "rollForward": "latestPatch" //default value, for clarity
  }
}

Expected behavior: Comments should work

Actual behavior: Error: Unexpected token / in JSON at position 72

IvanZosimov commented 1 year ago

Hi, @leotsarev 👋 Thanks for the issue! To try this functionality you may use main tag instead of v3.2.0 as this functionality is merged to main but isn't yet released. As soon as the new version of action is released, I'll ping you.

leotsarev commented 1 year ago

Thanks!

IvanZosimov commented 7 months ago

Hi, @leotsarev 👋 The new v4 version of setup-dotnet is released and it allows functionality you asked in this issue.

leotsarev commented 7 months ago

@IvanZosimov thanks!