actions / setup-dotnet

Set up your GitHub Actions workflow with a specific version of the .NET core sdk
MIT License
942 stars 458 forks source link

Node.js 16 actions are deprecated #503

Closed dmstrat closed 8 months ago

dmstrat commented 8 months ago

Description: Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-dotnet@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Task version: v2

Platform:

Runner type:

Repro steps:
Run Action

Expected behavior: Action runs using Node.js version 20+

Actual behavior: Action runs using Node.js version 16

aparnajyothi-y commented 8 months ago

Hello @dmstrat Thank you for creating this issue and we will look into the issue :)

Werebunny commented 8 months ago

Note this happens on all platforms and not just Ubuntu.

SimonBrettschneider commented 8 months ago

I can confirm it also happens on Windows.

mauricio-tamez commented 8 months ago

The latest version of setup-dotnet is v4, have you tried updating your workflow to use setup-dotnet@v4 ? That solved the issue for me.

gabrielweyer commented 8 months ago

502 updates the README to use the latest version.

dmstrat commented 8 months ago

come on @gabrielweyer That PR isn't even merged. =)

dmstrat commented 8 months ago

Tried the new @v4 of this action. Results are positive and no longer see the recommendation to upgrade. This issue can be closed.

dmstrat commented 8 months ago

This is no longer a bug but a documentation issue that #502 seems to fix once merged.

adriaanbalt commented 6 months ago

I'm using the generated Firebase YAML file for Hosting. It looks like this:

name: Deploy to Firebase Hosting on merge
'on':
  push:
    branches:
      - main
jobs:
  build_and_deploy:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v4
      - run: cd packages/website && yarn && yarn build
      - uses: FirebaseExtended/action-hosting-deploy@v0
        env:
          FIREBASE_CLI_EXPERIMENTS: webframeworks
        with:
          repoToken: '${{ secrets.GITHUB_TOKEN }}'
          firebaseServiceAccount: '${{ secrets.FIREBASE_SERVICE_ACCOUNT_COOLPROJECTNAME }}'
          channelId: live
          projectId: coolprojectname

the default uses actions/checkout@v3 but I've changed it to actions/checkout@v4. I'm still getting this error in Github workflow actions:

build_and_deploy Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: FirebaseExtended/action-hosting-deploy@v0. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

gabrielweyer commented 6 months ago

This is due to the FirebaseExtended/action-hosting-deploy@v0 GitHub Action. There is an opened issue, https://github.com/FirebaseExtended/action-hosting-deploy/issues/341, asking the maintainers to upgrade.

Sarfaraz021 commented 5 months ago

also, make sure to create a virtual environment and install all dependencies into that once all dependencies are installed then create requirements.txt file within the directory of the main code

noxidsoft commented 4 months ago

Also submitted here: https://github.com/actions/runner-images/issues/9920

Example YAML from link needs updating: https://docs.github.com/en/actions/publishing-packages/publishing-docker-images#publishing-images-to-docker-hub

Annotation from post successful action:


Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: docker/login-action@f4ef78c080cd8ba55a85445d5b36e214a81df20a, docker/metadata-action@9ec57ed1fcdbf14dcef7dfbe97b2010124a938b7, docker/build-push-action@3b5e8027fcad23fda98b2e3ac259d8d67585f671. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.```