actions / setup-go

Set up your GitHub Actions workflow with a specific version of Go
MIT License
1.41k stars 531 forks source link

chore: update to use go1.21 #410

Open chenrui333 opened 1 year ago

chenrui333 commented 1 year ago

Description: With go1.21 release, bump the golang usage/docs to it

Related issue: n/a

Check list:

dsame commented 1 year ago

The check has failed https://github.com/actions/setup-go/actions/runs/5821942042/job/15811878197?pr=410 because the PR should wait till the 1.21 has been deployed to the runners.

dsame commented 1 year ago

I checked the default go is not 21 yet

chenrui333 commented 1 year ago

rebased to the latest main and rerun the build

chenrui333 commented 1 year ago

cc @dsame @dmitry-shibanov

cageyv commented 1 year ago

cc @dsame @dmitry-shibanov Anything we could do to help you make it done ? Look like setup-go is a bit behind now :(

chenrui333 commented 1 year ago

ping @dsame @dmitry-shibanov

dmitry-shibanov commented 1 year ago

Thank you for your changes @chenrui333. Could you please revert changes related to actions/checkout and extra spaces.

chenrui333 commented 1 year ago

sorry about the hassle, I just recommit the change, which is better for review now :) (not sure how I messed up with the master branch merge commit 😮‍💨 )

chenrui333 commented 1 year ago

Thanks for the patience :)

Jayzon2019 commented 1 year ago

Encountered below issue when running Azure DevOps pipeline. Version 1.19 is the current working at my end.

[error]Failed to download version 1.21. Please verify that the version is valid and resolve any other issues. Error: Unexpected HTTP response: 404

I think, it downloads from this link https://storage.googleapis.com/golang/go1.21.windows-amd64.zip which is empty.

Could somebody help me on this.

Thanks in advance.

chenrui333 commented 1 year ago

@Jayzon2019 you should use 1.21.0 or 1.21.1 rather than 1.21, which would resolve your issue

Jayzon2019 commented 1 year ago

@chenrui333 . A thousand thanks to you.

I tried 1.21.1 and it was successful. I appreciate the immediate assistance.