actions / setup-go

Set up your GitHub Actions workflow with a specific version of Go
MIT License
1.41k stars 531 forks source link

Problem matchers: Matches of test failures #422

Open WillAbides opened 1 year ago

WillAbides commented 1 year ago

Description:

Currently test failures do not get annotated because the problem matcher requires that a column number be present, but go's test output does not include a column for test failures.

An example line that gets missed by the current matcher is:

/path/to/main_test.go:13: expected true but got false

The updated matcher makes the column number optional and matches the line above.

Check list:

dsame commented 1 year ago

Hello @WillAbides , we are starting to review the PR

WillAbides commented 1 year ago

You might want to hold off on this one for a bit. I used this same strategy in another action and got this report about it.

This pattern also matches test log statements, so those are getting annotated as failures even when the test passes.