fix: add arch to cache key

actions / setup-go

Set up your GitHub Actions workflow with a specific version of Go

MIT License

1.41k stars 531 forks source link

fix: add arch to cache key #493

Closed Zxilly closed 2 months ago

Zxilly commented 4 months ago

Description:

GitHub has added the arm64 runner, so arch should be used as part of the cache key. Otherwise, if there are macos-13 macos-14 running at the same time, the late executor will get the wrong cache.

Check list:

[ ] Mark if documentation changes are required.
[x] Mark if tests were added or updated to cover the changes.

kolyshkin commented 3 months ago

See also: #368, #383

Zxilly commented 3 months ago

@kolyshkin This mainly happens on macOS amd64/arm64, and the previous patch didn't resolve it.

kolyshkin commented 3 months ago

@kolyshkin This mainly happens on macOS amd64/arm64, and the previous patch didn't resolve it.

I agree. Yet one day we'll have Windows and Linux on ARM and this will be needed there as well. Thanks for adding, LGTM(NB).

Zxilly commented 3 months ago

For GitHub Enterprise we already have Linux arm64 provided by ARM.