search

actions / setup-java

Set up your GitHub Actions workflow with a specific version of Java
MIT License
1.56k stars 744 forks source link

Input property that would configure if the JDK should be configured as default or not #560

Open vlsi opened 11 months ago

vlsi commented 11 months ago

Description:

Currently, setup-java configures the installed Java as default, however, there are cases when no change in JAVA_HOME is needed.

I suggest adding configure-as-default boolean input field (default true) so users could opt-out of configuring the installed Java for the default one.

Justification:

https://github.com/oracle-actions/setup-java downloads java binary, and it then calls actions/setup-java to set it up.

I use oracle-actions/setup-java to fetch Java EA (e.g. Java 22). I do not want Java 22 to be set as default since it would fail the build (e.g. Gradle does not yet support running with Java 22). I need Java 22 for tests only, so I want Java 22 to be present, however, I would like to keep JAVA_HOME untouched.

Are you willing to submit a PR?

Maybe

IvanZosimov commented 11 months ago

Hi, @vlsi 👋 Thanks for the feature request! We will take a look and let you know about our decision.