search

actions / setup-node

Set up your GitHub Actions workflow with a specific version of node.js
MIT License
3.87k stars 1.26k forks source link

Support node.js mirror like nvm #730

Open thomas-z-meyer-db opened 1 year ago

thomas-z-meyer-db commented 1 year ago

Description: Support alternate nodejs download mirror like nvm

nvm does support setting a mirror via environment variable, e.g: NVM_NODEJS_ORG_MIRROR=https://artifactory.company.com/artifactory/node-dist/

setup-node should also support a similar option "mirror" to specify an alternate node.js base URL for downloading the node.js binaries.

Justification: All node.js binaries are downloaded directly from the internet via a specified proxy in the github action runners environment, which created egress costs for self-hosted github action runners in GHEC.

By using mirror option the reliance on node.js site is decoupled and egress is saved.

Are you willing to submit a PR? i think i'm not allowed...

MaksimZhukov commented 1 year ago

Hello @thomas-z-meyer-db ! Thank you for the suggested idea! We will consider adding this feature and will let you know as soon as we have any decision.

Santas commented 1 year ago

nodejs.org seems to fail quite often in the recent weeks. Having a possibility to specify a mirror would be great.

bgalek commented 1 year ago

Hi! I'm also affected by nodejs.org fails. Is setup-node action caching the node tarball, so it's not downloaded every time? https://github.com/actions/toolkit/tree/main/packages/tool-cache

dariusz22p commented 1 year ago

NodeJs has been timing out a lot in recent days for us, so this feature would make our life much easier

yeikel commented 1 year ago

Is this feature open for OSS contributions?

zhyc9de commented 1 week ago

https://github.com/actions/setup-node/pull/134 can resolve this problom, can we merge it ?