actions / setup-node

Set up your GitHub Actions workflow with a specific version of node.js
MIT License
3.87k stars 1.26k forks source link

Add lts alias for lts/* #996

Open zdm opened 6 months ago

zdm commented 6 months ago

Description: Could you please add simple lts alias for the latest lts version in addition to the lts/*? lts/* is not obvious, ugly and confusing.

If ypu don't want to do this - please, close this issue immediately,

HarithaVattikuti commented 6 months ago

Hello @zdm Thank you for creating this feature request. We will investigate it and get back to you as soon as we have some feedback.

ThePlenkov commented 1 month ago

oh wow! That's exactly how I reached here. So following the official doc page:

- uses: actions/setup-node@v4
  with:
    # Version Spec of the version to use in SemVer notation.
    # It also admits such aliases as lts, latest, nightly and canary builds
    # Examples: 12.x, 10.15.1, >=10.15.0, lts/Hydrogen, 16-nightly, latest, node
    node-version: ''

we can see It also admits such aliases as lts

but this is what we get in real:

Run actions/setup-node@v4
  with:
    node-version: lts
    registry-url: https://registry.npmjs.org/
    always-auth: false
    check-latest: false
    token: ***
Attempting to download lts...
Not found in manifest. Falling back to download directly from Node
voldemortensen commented 3 weeks ago

@ThePlenkov's experience is exactly how I ended up here as well. An lts alias would be great, but at a minimum the docs should be updated to be more clear.

GauthierPLM commented 2 weeks ago

Same feedback: the lts alias is described in the doc but doesn't work.

zdm commented 2 weeks ago

Is it possible to fix it? It will bee pretty easy to rename incoming tls option to lts/*.