Open hugovk opened 10 months ago
Hello @hugovk. Thank you for your feature request. We'll take a look on it.
Hello @dmitry-shibanov, any news?
The 3.13 beta is due on 2024-05-07 and we'll ask the community to start testing ahead of the full release in October. It would be very helpful if it's possible using GitHub Actions.
Thanks!
@dmitry-shibanov hi! 3.13 beta 1 was just released. Myself and a few others have been working on adding compatibility for free-threaded python builds and I'd like to start adding CI for some projects in the scientific python ecosystem. Being able to specify a build via setup-python
would make doing so much more straightforward for many projects.
@dmitry-shibanov Thanks for looking into making this happen. Is there anything you need from the Python community to make this happen within GitHub Actions?
For anyone seeking a workaround the deadsnakes action has a nogil flag https://github.com/deadsnakes/action
You can install Python 3.13 this way as a drop in replacement for the setup-python action.
I had a first look at how it could be implemented given the current state of things in actions:
That being said, the arch
field of the manifest is just a string so it could be used to provide variants (e.g. x64-nogil
).
This is probably not user friendly so while the actions/python-versions
repo could use such a hack, the actions/setup-pyton
might want to provide an option - as proposed in the description - and leave the hack as an internal detail that could be changed if manifest generation/consumption gets updated.
I'm willing to submit Pull Requests but need some guidance regarding what's acceptable from the maintainers first.
cc @dmitry-shibanov, @HarithaVattikuti, @aparnajyothi-y
I’m curious, with Python 3.13 now being in the release candidate phase, is anyone still working on this or discussing it?
I'm also curious if anyone has worked on this yet. For Windows, at least, the python-version
release installer for Windows seem to already have an installer capable of installing the free-threaded binary. Just need to update the setup.ps1
powershell script (that lives inside the zip) to pass the Include_freethreaded=1
option to the installer (and then maybe remove/rename the installed GIL binary python.exe
with the NOGIL binary python3.13t.exe
that is installed next to it).
e.g. here is how I've installed the 3.13rc1 nogil binary with a powershell script:
$pythonInstallerUrl = "https://www.python.org/ftp/python/3.13.0/python-3.13.0rc1-amd64.exe"
Invoke-WebRequest $pythonInstallerUrl -OutFile setup-python.exe
Start-Process "setup-python.exe" -argumentlist "/quiet PrependPath=1 TargetDir=C:\Python313 Include_freethreaded=1" -wait
Rename-Item -Path "C:\Python313\python.exe" -NewName "pythonw3.13.exe"
Rename-Item -Path "C:\Python313\python3.13t.exe" -NewName "python.exe"
Description:
Please make Python 3.13 available, built with the
--disable-gil
flag.Justification:
Thank you for actions/setup-python and especially for making it possible to test new pre-releases, and final releases within a day or so of their official release. (And see here how well GitHub Actions compares to other CI services :)
PEP 703 has been accepted to remove the GIL. The rollout is planned in three phases, and for success, it's extremely important to get community feedback and support to be able to move to the next phase.
Therefore it's also extremely important for the community to be able to test the "free-threaded" aka "nogil" builds of Python. This requires a separate build of 3.13 with the
--disable-gil
flag enabled for the configure script (see the PEP and CPython CI).To achieve this, it would be very helpful if actions/setup-python also provided free-threaded builds for 3.13 (and later) to enable the community to try them out and give feedback, perhaps via
with: disable-gil: true
.It's still a bit early for extension authors to start testing, but it would be great to have the testing infra ready for when the time comes.
Would this be possible?
Are you willing to submit a PR?
Yes.