search

actions / setup-python

Set up your GitHub Actions workflow with a specific version of Python
MIT License
1.59k stars 505 forks source link

no such option: --root-user-action #853

Closed HKongCC closed 1 month ago

HKongCC commented 2 months ago

Description: Unable to setup-python@v4. Fails on downloading pip packages, was working yesterday, but the same workflow fails today.

Update: Also appears that yesterday it successfully upgraded pip to 24.0 so it had the --root-user-action argument available, but today the upgrade isn't happening and stays on 22.0.4 properly so the --root-user-action argument is throwing an error.

Action version: setup-python@v4

Platform:

Runner type:

Tools version: Python 3.9.13

Repro steps:
Use actions/setup-python@v4, with python version 3.9.13, and x64 architecture

Expected behavior: Setup python successfully

Actual behavior: Fails on pip install with the following message no such option: --root-user-action

forgingdestiny commented 2 months ago

+1 seeing similar issue on v2 and v4

benterem commented 2 months ago

+1 same

KodiaqQ commented 2 months ago

Try to change to Python versions older than 12h ago in actions - https://github.com/actions/python-versions/releases (found it spontaneously) upd. For example, switch from broken 3.8.10 to 3.8.18 solves the issue.

HKongCC commented 2 months ago

Good eye @KodiaqQ , looks like this is the breaking PR for those versions https://github.com/actions/python-versions/pull/259

KodiaqQ commented 2 months ago

Good eye @KodiaqQ , looks like this is the breaking PR for those versions actions/python-versions#259

Yeah. We've found this PR earlier than a solution with a version switch.

tblom commented 2 months ago

Same on v5

forgingdestiny commented 2 months ago

Does anyone know if there will be a new release or something similar to fix? Using a different python version isn't an option for most production builds without going through an upgrade process. 🤔 thinking through alternatives here. the pinned version should prevent this fwiw.

Rjevski commented 2 months ago

@HKongCC had a quick look and doesn't seem like that's the case unfortunately - I don't see any parameter here that would allow to override it. I temporarily switched my affected projects to use 3.9.19 version which seems unaffected. Obviously hoping that upstream will yank the broken 3.9.13 build so I can roll back my workaround.

HarithaVattikuti commented 2 months ago

Hello @HKongCC Thank you for creating this issue. We will investigate it and get back to you as soon as we have some feedback.

aram-eskandari commented 2 months ago

i can confirm what @Rjevski already stated: upgrading from my old version of 3.9.13 to 3.9.19 worked. Whenever this issue is resolved i will revert my project back to 3.9.13.

goharShoukat commented 2 months ago

Do we have an ETA on this? Moving Production builds to a newer version is not quite as straightforward!

Rjevski commented 2 months ago

@goharShoukat you could look into using PyEnv in the meantime? A bit of manual work but should be doable if it's time-critical.

goharShoukat commented 2 months ago

@goharShoukat you could look into using PyEnv in the meantime? A bit of manual work but should be doable if it's time-critical.

How do you mean? PyEnv would only let me switch versions of Python but the code and other packages need to be appropriately adjusted if I switch over to a different python version.

Rjevski commented 2 months ago

@goharShoukat I meant use PyEnv to install 3.9.13 instead of using the GH Actions' broken build. Effectively remove your "setup-python" action and just install & call pyenv like you would on any other Linux machine.

priya-kinthali commented 2 months ago

Hello @HKongCC , Could you please provide a link to a minimal reproduction of the issue/workflow steps? It would be very helpful in addressing your problem. Thank you!

sikander27 commented 2 months ago

+1, facing same issue and looks like this https://github.com/actions/python-versions/commit/29394d004242dde117bb805900c99409a93b689c PR break it :(

cognifloyd commented 2 months ago

Looks like the --root-user-action arg was added in https://github.com/actions/python-versions/pull/223 (https://github.com/actions/python-versions/commit/b539ede4c3ac9de14c32aab0c4fdd0278fe45ec0), and then it was removed for macos runners in https://github.com/actions/python-versions/pull/259 (https://github.com/actions/python-versions/commit/29394d004242dde117bb805900c99409a93b689c), but it is still present for the linux runners.

I'm seeing this failure on ubuntu-20.04:

  Version 3.8.10 was not found in the local cache
  Version 3.8.10 is available for downloading
  Download from "https://github.com/actions/python-versions/releases/download/3.8.10-8833490298/python-3.8.10-linux-20.04-x64.tar.gz"
  Extract downloaded archive
  /usr/bin/tar xz --warning=no-unknown-keyword --overwrite -C /home/runner/work/_temp/2f150651-7ec7-4a06-b868-a38da9fd2828 -f /home/runner/work/_temp/9035f184-4c44-46b2-bda5-30215c62bd33
  Execute installation script
  Check if Python hostedtoolcache folder exist...
  Create Python 3.8.10 folder
  Copy Python binaries to hostedtoolcache folder
  Create additional symlinks (Required for the UsePythonVersion Azure Pipelines task and the setup-python GitHub Action)
  Upgrading pip...
  Looking in links: /tmp/tmp1b6088ml
  Requirement already satisfied: setuptools in /opt/hostedtoolcache/Python/3.8.10/x64/lib/python3.8/site-packages (56.0.0)
  Requirement already satisfied: pip in /opt/hostedtoolcache/Python/3.8.10/x64/lib/python3.8/site-packages (21.1.1)
  Error: Usage:   
    /opt/hostedtoolcache/Python/3.8.10/x64/bin/python -m pip install [options] <requirement specifier> [package-index-options] ...
    /opt/hostedtoolcache/Python/3.8.10/x64/bin/python -m pip install [options] -r <requirements file> [package-index-options] ...
    /opt/hostedtoolcache/Python/3.8.10/x64/bin/python -m pip install [options] [-e] <vcs project url> ...
    /opt/hostedtoolcache/Python/3.8.10/x64/bin/python -m pip install [options] [-e] <local project path> ...
    /opt/hostedtoolcache/Python/3.8.10/x64/bin/python -m pip install [options] <archive url/path> ...

  no such option: --root-user-action
  Error: The process '/usr/bin/bash' failed with exit code 2

So, this build of python 3.8.10 has pip 21.1.1, but the --root-user-action option was added in https://github.com/pypa/pip/pull/11035 (https://github.com/pypa/pip/commit/2e1112a8141dbdf767505fded918706e9ad61031) which was only released in pip 22.1 and greater.

Where is the version of pip embedded in the python-version build defined? Either the python build needs a newer version of pip, or the linux script needs to use the env var similar to the macos fix.

mayeut commented 2 months ago

I only expected missing macOS arm64 versions to be added when opening https://github.com/actions/python-versions/pull/259

It seems that rather than adding the missing platform, every platform was rebuilt and published...

Where is the version of pip embedded in the python-version build defined?

The initial version comes from the python sources/binaries (built or fetched depending on OS/platform). It's tightly coupled to the version of python.

Either the python build needs a newer version of pip, or the linux script needs to use the env var similar to the macos fix.

I do have a PR on the way to fix that on every platform, it will need the maintainers to approve it & rebuild everything once again.

Keshapally commented 2 months ago

+1

cognifloyd commented 2 months ago

With the latest build of python 3.8.10, I'm no longer seeing this issue. Thanks for fixing it @mayeut.

aparnajyothi-y commented 1 month ago

Hello Everyone, New artifacts have been generated. Please rerun the actions and let us know if you still see any issues. Thank you @mayeut for your contribution with the PR.

goharShoukat commented 1 month ago

Hello Everyone, New artifacts have been generated. Please rerun the actions and let us know if you still see any issues. Thank you @mayeut for your contribution with the PR.

Works for me! Thanks for the quick fix!

aparnajyothi-y commented 1 month ago

Hello @HKongCC, We are closing this issue as it is fixed and confirmed by everyone. Please feel free to reach us if you are still facing the same issue.