actions / stale

Marks issues and pull requests that have not had recent interaction
MIT License
1.35k stars 359 forks source link

Exclude unchecked days from staleness computation #1051

Open ozydingo opened 1 year ago

ozydingo commented 1 year ago

Description: The staleness check / reminder is a great feature, and our teams are using it to maintain a tight feedback loop. We warn about PRs that are 2+ days stale, and overall this is a great experience. We have the reminder set to "weekdays", so that reminders are not sent on non-working days, which is a great addition!

However, the checked days seem to only affect which days reminders are sent, not which days are used to compute staleness. If a developer opens a PR later Friday, we are getting the notification and and downstream automations based on that notification on Monday, practically before anyone has had a chance to even see that the PR exists.

An opt-in (e.g. checkbox) or default feature to exclude the same days that are disabled for the reminder from the staleness computation would really make a difference here! I recognize that the staleness computation becomes a bit more tricky to perform, but the feature is really half-baked without this ability, for the reason illustrated by above-stated use case

Justification:

See description for an example use case. This issue has been raised before, but has gone stale (oh, the irony :-P).

The proposal would be something like adding a checkbox to this screen:

Screen Shot 2023-07-10 at 9 40 58 AM

that would allows "ignore unchecked days in staleness computation". This allows the feature to be backwards compatible, but opt-in for folks who want this feature.

Are you willing to submit a PR?

Given time, absolutely, though that's pretty unlikely in the next couple months.

dusan-trickovic commented 1 year ago

Hello, @ozydingo ! Thank you for reporting this issue, we will investigate it and see what can be done :)

mhornfeck-cc commented 6 months ago

@dusan-trickovic any potential for movement on this? Our team has just started using the reminders feature and we love it - but adding some flex here for ignoring weekend days for staleness would be awesome.