actions / stale

Marks issues and pull requests that have not had recent interaction
MIT License
1.34k stars 353 forks source link

Stale label not removed after receiving comments/commit #1132

Open joaopgrassi opened 7 months ago

joaopgrassi commented 7 months ago

Description: I recently enabled the stable bot PR here. Yesterday I noticed a PR that clearly had updates, but the Stale label is still not removed from the PR. I looked into the PR and here is the timeline:

That is also consistent with what it is shown in the logs:

image

Action version: 2.312.0

Platform:

Runner type:

Repro steps:
Last job execution: https://github.com/open-telemetry/semantic-conventions/actions/runs/7750945678/job/21137993067 Affected PR: https://github.com/open-telemetry/semantic-conventions/pull/627

Expected behavior: The Stale label to be removed, since the PR received updates/activity:

Actual behavior: The Stale label is there.

I'm not sure if I'm missing any configuration, but with the defaults it seems it should work:

If an update/comment occur on stale issues or pull requests, the stale label will be removed and the timer will restart

joaopgrassi commented 7 months ago

Another example here https://github.com/open-telemetry/semantic-conventions/pull/600

HarithaVattikuti commented 7 months ago

Hello @joaopgrassi Thank you for creating this issue. We will investigate it and get back to you as soon as we have some feedback.

rcomer commented 6 months ago

Does the issue persist since you bumped the version?

joaopgrassi commented 6 months ago

I have not seen it anymore, but it could be that I'm just not looking hard enough. I will try to keep an eye and see if anything gets closed unintentionally.

tari3x commented 3 months ago

I think I saw exactly the same issue in https://github.com/instaloader/instaloader/issues/2172. I replied to prevent the bot from closing the issue, but it closed it nevertheless.