actions / starter-workflows

Accelerating new GitHub Actions workflows
https://github.com/features/actions
Other
8.6k stars 5.09k forks source link

Update for `gradle/actions@v3.0.0` release #2290

Closed bigdaz closed 5 months ago

bigdaz commented 5 months ago

This PR updates the existing gradle.yml and gradle-publish.yml starter workflows for recent updates to gradle/gradle-build-action.

Pre-requisites


Please note that at this time we are only accepting new starter workflows for Code Scanning. Updates to existing starter workflows are fine.


Tasks

For all workflows, the workflow:

For CI workflows, the workflow:

For Code Scanning workflows, the workflow:

Some general notes:

bigdaz commented 5 months ago

I added some documentation and removed the "optional" flag from 'dependency-submission'.

Could you also add some explanation in a comment as to the change to running gradlew instead of running gradle-build-action ?

I presume this is targeted at new users of GitHub + Gradle, so I don't think it makes sense to document this as a change. It's natural for folks to run some sort of "setup" step followed by calling the build tool directly: having gradle-build-action do the execution was an anomaly IMHO.

I did add a section showing what is required in the usual case that a user doesn't have the Gradle wrapper configured for their project. It looks a bit verbose, but it's complete.