Workflows should be using setup-dotnet v4 (roughly https://github.com/actions/setup-dotnet/releases/tag/v4.0.0, plus later updates). It doesn't have breaking changes. Some workflows in this repository are already using it. There's no reason to inconsistently use v2/v3/v4.
There is a "breaking change" between v2 and v3 https://github.com/actions/setup-dotnet/blob/main/docs/adrs/v3-setup-dotnet.md#breaking-changes, but the only instance of v2 is in a comment, so this is harmless. The step would only be needed for private runners without dotnet, or with an old dotnet -- in any case, afaict based on the release notes, this behavior would be fine since the tool in question just wants "new enough" not "precise".
Pre-requisites
[ ] Prior to submitting a new workflow, please apply to join the GitHub Technology Partner Program: partner.github.com/apply.
Please note that at this time we are only accepting new starter workflows for Code Scanning. Updates to existing starter workflows are fine.
Tasks
For all workflows, the workflow:
[ ] Should be contained in a .yml file with the language or platform as its filename, in lower, kebab-cased format (for example, docker-image.yml). Special characters should be removed or replaced with words as appropriate (for example, "dotnet" instead of ".NET").
[ ] Should use sentence case for the names of workflows and steps (for example, "Run tests").
[ ] Should be named only by the name of the language or platform (for example, "Go", not "Go CI" or "Go Build").
[ ] Should include comments in the workflow for any parts that are not obvious or could use clarification.
[ ] Should specify least privileged permissions for GITHUB_TOKEN so that the workflow runs successfully.
[ ] Should run on push to branches: [ $default-branch ] and pull_request to branches: [ $default-branch ].
[ ] Packaging workflows should run on release with types: [ created ].
[ ] Publishing workflows should have a filename that is the name of the language or platform, in lower case, followed by "-publish" (for example, docker-publish.yml).
[ ] creator: Name of the organization/user producing the Code Scanning integration.
[ ] description: Short description of the Code Scanning integration.
[ ] categories: Array of languages supported by the Code Scanning integration.
[ ] iconName: Name of the SVG logo representing the Code Scanning integration. This SVG logo must be present in the icons directory.
[ ] Should run on push to branches: [ $default-branch, $protected-branches ] and pull_request to branches: [ $default-branch ]. We also recommend a schedule trigger of cron: $cron-weekly (for example, codeql.yml).
[ ] This workflow must only use actions that are produced by the language or ecosystem that the workflow supports. These actions must be published to the GitHub Marketplace. We require that these actions be referenced using the full 40 character hash of the action's commit instead of a tag. Additionally, workflows must include the following comment at the top of the workflow file:
# This workflow uses actions that are not certified by GitHub.
# They are provided by a third-party and are governed by
# separate terms of service, privacy policy, and support
# documentation.
[ ] Automation and CI workflows should not send data to any 3rd party service except for the purposes of installing dependencies.
[ ] Automation and CI workflows cannot be dependent on a paid service or product.
Workflows should be using setup-dotnet v4 (roughly https://github.com/actions/setup-dotnet/releases/tag/v4.0.0, plus later updates). It doesn't have breaking changes. Some workflows in this repository are already using it. There's no reason to inconsistently use v2/v3/v4.
There is a "breaking change" between v2 and v3 https://github.com/actions/setup-dotnet/blob/main/docs/adrs/v3-setup-dotnet.md#breaking-changes, but the only instance of
v2is in a comment, so this is harmless. The step would only be needed for private runners without dotnet, or with an old dotnet -- in any case, afaict based on the release notes, this behavior would be fine since the tool in question just wants "new enough" not "precise".Pre-requisites
Please note that at this time we are only accepting new starter workflows for Code Scanning. Updates to existing starter workflows are fine.
Tasks
For all workflows, the workflow:
.ymlfile with the language or platform as its filename, in lower, kebab-cased format (for example,docker-image.yml). Special characters should be removed or replaced with words as appropriate (for example, "dotnet" instead of ".NET").GITHUB_TOKENso that the workflow runs successfully.For CI workflows, the workflow:
cidirectory.ci/properties/*.properties.jsonfile (for example,ci/properties/docker-publish.properties.json).pushtobranches: [ $default-branch ]andpull_requesttobranches: [ $default-branch ].releasewithtypes: [ created ].docker-publish.yml).For Code Scanning workflows, the workflow:
code-scanningdirectory.code-scanning/properties/*.properties.jsonfile (for example,code-scanning/properties/codeql.properties.json), with properties set as follows:name: Name of the Code Scanning integration.creator: Name of the organization/user producing the Code Scanning integration.description: Short description of the Code Scanning integration.categories: Array of languages supported by the Code Scanning integration.iconName: Name of the SVG logo representing the Code Scanning integration. This SVG logo must be present in theiconsdirectory.pushtobranches: [ $default-branch, $protected-branches ]andpull_requesttobranches: [ $default-branch ]. We also recommend ascheduletrigger ofcron: $cron-weekly(for example,codeql.yml).Some general notes:
actionsorganization, or