search

actions / starter-workflows

Accelerating new GitHub Actions workflows
https://github.com/features/actions
Other
8.69k stars 5.11k forks source link

Would you like a Create React App starter workflow PR? #2446

Open beveradb opened 1 month ago

beveradb commented 1 month ago

Hey folks,

I just spent way longer than I expected trying to get a simple Create React App project deployed to github pages using github actions 😞

I created this gist with my final code: https://gist.github.com/beveradb/92f9a7a56f761eaf31f3396e5e867f4f

Would y'all like me to raise a PR in this repo adding a starter workflow for react?

Cheers, Andrew

janbrasna commented 4 weeks ago

There is nothing special to CRA workflow compared to any generic "npm run build" project, but yea I'd love to see a basic node/npm/webpack project building and publishing as a blueprint, too. (Got surprised when trying the starter workflows myself that anything Node- or Webpack-related is basically just for general CI testing, no example showing how to actually build the artifacts and publish them.)

Regarding this, CRA is basically "unmaintained" nowadays so it's not a good candidate to be added (also don't really fancy npm install instead of npm ci here and CI=false etc. as a good example exactly, some actions would use a version bump as well as node version etc.) but generally just with some added concurrency that's basically what we're using…

According to the project status, maintainers don't currently accept new additions for static generators. I'd vouch for a node-npm-webpack-type-of-project build and deploy example of a similar kind to be added, though.