actions / toolkit

The GitHub ToolKit for developing GitHub Actions.
https://github.com/features/actions
MIT License
4.9k stars 1.4k forks source link

Download tool method in tool-cache package should allow passing http request options #1117

Open rprakashg-redhat opened 2 years ago

rprakashg-redhat commented 2 years ago

I think it would be great if the download tool method in tool cache package should allow a way to set http request options like ignore SSL errors I'm fairly new to this and just not seeing any way to do this. Currently using this to download a cli from an endpoint, its a dev environment and due to SSL cert errors not able to download the tool

rprakashg-redhat commented 2 years ago

const http = new httpm.HttpClient(userAgent, [], { allowRetries: false }) above lines of code in download tool attempt method instead of hard coding should allow clients to pass this,

rprakashg-redhat commented 2 years ago

I can make this change and submit PR if you all are ok with this change

sethfaulkner commented 1 year ago

Was this resolved?

rprakashg-redhat commented 1 year ago

no body every responded so I wasn't sure. I have the change in my fork

duxbuse commented 1 year ago

@rentziass Would really appreciate your 👀 if this approach is ok.

Not being able to set certificates for requests, makes the downloadTool quite impotent.