actions / toolkit

The GitHub ToolKit for developing GitHub Actions.
https://github.com/features/actions
MIT License
4.93k stars 1.42k forks source link

Fix regression, auto readlink on symlinks again #1830

Open robherley opened 1 week ago

robherley commented 1 week ago

With the changes introduced in:

Which was meant to resolve:

We introduced a new bug:

We had a slight regression with symlinks. The typical behavior is that they are auto-resolved and the contents of the zip are added at the link's location. With the lazy-stream wrapper being used, it did not resolve the symlinks.

This PR switches our stat to an lstat, and we can check for a symbolic link, then resolve it, when we add the file to the zip archive.