"npm test" script eats failure-status (because "|| make-coverage-badge")

[ebrannin-bw]

The npm test script eats failures, and breaks && in npm run all:

{
    "test": "(jest && make-coverage-badge --output-path ./badges/coverage.svg) || make-coverage-badge --output-path ./badges/coverage.svg",
    "all": "npm run format:write && npm run lint && npm run test && npm run package"
}

Because it runs make-coverage-badge on test failure, when I run npm run all it will run npm run package even if tests fail.

[ebrannin-bw]

This also breaks VS Code's Jest integration, because it expects to run npm test -- --flag ... and have the new arguments go to Jest.

I've fixed it in my repo by:

• Removing make-coverage-badge from npm test
• Adding coverage-badge as its own script
• Adding it to npm run all, as in: && npm test && npm run coverage-badge

[ncalteen]

Hey @ebrannin-bw, thanks for catching that! I've submitted #805 to fix this error using the workaround you provided :)