search

actions / typescript-action

Create a TypeScript Action with tests, linting, workflow, publishing, and versioning
https://github.com/actions
MIT License
2k stars 473 forks source link

test: type the @actions/core spy/mock from the actual implementations #866

Closed ammmze closed 7 months ago

ammmze commented 7 months ago

This allows the mockImplementation calls to automatically be typed based on the official @actions/core type definitions rather than having to define them manually.

ncalteen commented 7 months ago

:wave: @ammmze Thanks for the PR! It's always helpful to have correct types in place!

Can you just make sure to run formatting against the changes? Looks like they're flagging on a couple small things.

ammmze commented 7 months ago

👋 @ammmze Thanks for the PR! It's always helpful to have correct types in place!

Can you just make sure to run formatting against the changes? Looks like they're flagging on a couple small things.

👍🏻 You got it! Thanks for taking a look.