actions / upload-artifact

MIT License
3.26k stars 739 forks source link

[docs] Warn about empty directories in artifacts #392

Open orensbruli opened 1 year ago

orensbruli commented 1 year ago

What files would you like to change?

README.md

What are your suggested changes?

I think it would be worth mentioning the filtering of empty directories. https://github.com/actions/upload-artifact/blob/65d862660abb392b8c4a3d1195a2108db131dd05/src/search.ts#L99-L100 I think by default, if we add a path, we expect to see it in the artifact that is generated, even if it is empty, another way we tend to think that something went wrong with the configuration of the action. Since this is not the case, I think it would be good to let the user know that the lack of empty directories is the expected behavior.

orensbruli commented 1 year ago

PR https://github.com/actions/upload-artifact/pull/393