search

actions / upload-artifact

MIT License
3.16k stars 710 forks source link

[feat req] Support setting compression level #398

Closed 8MiYile closed 9 months ago

8MiYile commented 1 year ago

What would you like to be added?

want support setting compression level

Why is this needed?

Because I found a problem in the build The difference in footprint between two compressions and one compression is half https://github.com/8Mi-Tech/CefDetectorX/actions/runs/4675681366 https://github.com/8Mi-Tech/CefDetectorX/actions/runs/4662555125

https://computingforgeeks.com/highest-zip-compression-level-on-linux/#:~:text=Tthe%20total%20number%20of%20zip%20compression%20levels%20is,suffix%20list%29.%20The%20default%20compression%20level%20is%20-6.

8MiYile commented 1 year ago

old

- uses: actions/upload-artifact@v2
  with:
    name: my-artifact
    path: path/to/artifacts/

new

- uses: actions/upload-artifact@v2
  with:
    name: my-artifact
    path: path/to/artifacts/
    type: zip
    level: -8
konradpabjan commented 9 months ago

v4 has been released today and with it there is an option to set the compression level with the compression-level input: https://github.com/actions/upload-artifact?tab=readme-ov-file#altering-compressions-level-speed-v-size

See https://github.blog/changelog/2023-12-14-github-actions-artifacts-v4-is-now-generally-available/