search

actions / upload-artifact

MIT License
3.16k stars 710 forks source link

[feat req] v4: add option to disable the 10 artifacts per job limit #470

Closed database64128 closed 9 months ago

database64128 commented 9 months ago

What would you like to be added?

An option to remove the limit and restore the old behavior (before v4).

Why is this needed?

I have a workflow that needs to upload 24 artifacts in a single job. It is not possible to split the workflow into multiple jobs.

siegfriedpammer commented 9 months ago

Is there any documentation or explanation for why this limit was added in the first place?

JackCoplandGranta commented 9 months ago

Would be useful. we have a build that outputs 15 that caught us out when we tried to upgrade to v4. For anyone else in the same situation you can do a mix to take advantage of the speed gain - pick your 10 largest artifacts in that job and output them using v4, and use v3 for the others.

robherley commented 9 months ago

@JackCoplandGranta @siegfriedpammer @database64128

👋 The limit has been raised to 500 Artifacts per job.

We chose to introduce a limit to avoid abuse scenarios. We did some data analysis, the 10 artifacts limit covered covered ~93% of all the workflow runs on GitHub.

We decided to raise it to 500 to avoid any friction without risk of abuse. Having 500 per job covers 99.99% of runs on GitHub.

database64128 commented 9 months ago

Thanks. 500 sounds like a reasonable limit.