search

actions / upload-artifact

MIT License
3.26k stars 739 forks source link

[feat req] GHES Support #537

Open dcaffull-fds opened 8 months ago

dcaffull-fds commented 8 months ago

What would you like to be added?

I see that v4 does not have GHES support. The changelog states that support will be added in the future, but I don't see any issue tracking that, so thought I'd file this.

If any approximate timelines are available, I'd appreciate it. Thanks.

Why is this needed?

My company uses GHES and would like to stay up to date with our dependencies. Currently we are forced to remain on v3 of this action.

Danielku15 commented 7 months ago

Found this: https://github.com/github/roadmap/issues/930 I think it is a backend topic if GHES to be compatible with the action itself. Seems it is only planned for Q4 2024 which is a very unfortunate statement.

mgasner commented 3 months ago

this is especially tricky since it seems like the response for certain classes of issues is "upgrade to v4": https://github.com/actions/upload-artifact/issues/388

AndreasAugustin commented 3 months ago

Screenshot 2024-08-23 at 14 43 55

Related to https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/ v3 won't work anymore starting November 30, 2024.

We are using this action (and also actions/download-artifact) within our GHES.

My question is if v4 will be supported for GHES until the mentioned date or if we need to find other solutions? Thanks

Danielku15 commented 3 months ago

If we're lucky we might get v4 support in Q1-2025. The implementation is planned for Q4-2024 and it will take until we get a release.

But from the message I read: "...This deprecation will not impact any existing versions of GitHub Enterprise Server being used by customers". Hence v3 is still "there" but considered deprecated.

GammaGames commented 1 month ago

Especially annoying because other self-hosted servers already support the protocol and we still can't use the action without patching it :roll_eyes:

ctsalidis commented 3 weeks ago

Is there any update in regards to using v4 on GHES?

trevor-moore-dev commented 2 weeks ago

Is there any update in regards to using v4 on GHES?

I second this question. We're midway through Q4 2024 and I'm hoping it'll still get released before end of the year 🤞

Danielku15 commented 2 weeks ago

No info about it in the GHES 3.15 Release notes 😭

https://docs.github.com/en/enterprise-server@3.15/admin/release-notes