nonesky666
commented
2 months ago Great 👍😃
On Thu, Mar 21, 2024, 12:54 PM Andreas Gajdosik @.***> wrote:
What would you like to be added?
In v3 the github action was adding directory entries into the zip, as could be seen in the outputs of:
zfile12 = zipfile.ZipFile("some.zip", "r")for file in zfile11.namelist(): print(file)
For v4:
blenderkit/init.py blenderkit/addon_updater.py blenderkit/addon_updater_ops.py blenderkit/append_link.py blenderkit/asset_bar_op.py blenderkit/asset_drag_op.py blenderkit/asset_inspector.py [...]
For v3:
blenderkit/ blenderkit/bl_ui_widgets/ blenderkit/blendfiles/ blenderkit/client/ blenderkit/data/ blenderkit/thumbnails/ blenderkit/addon_updater.py blenderkit/autothumb_material_bg.py blenderkit/ui_panels.py [...]
Why is this needed?
Missing the directory entries is not bad per se, but some other code might depend on it, for us it is CGCookie/blender-addon-updater#90 https://github.com/CGCookie/blender-addon-updater/issues/90.
Having option to include explicit directory entries would enable me to continue using the artifact-upload. Other options would be to allow uploading the zip directly, that way I would have the full control. But until then, I will need to upload manually again...
— Reply to this email directly, view it on GitHub https://github.com/actions/upload-artifact/issues/547, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXNMDT3II3UXCJ5ITQXPIJ3YZLC55AVCNFSM6AAAAABFBJMSKGVHI2DSMVQWIX3LMV43ASLTON2WKOZSGE4TSOJXHA3DCMA . You are receiving this because you are subscribed to this thread.Message ID: @.***>
What would you like to be added?
In v3 the github action was adding directory entries into the zip, as could be seen in the outputs of:
For v4:
For v3:
Why is this needed?
Missing the directory entries is not bad per se, but some other code might depend on it, for us it is https://github.com/CGCookie/blender-addon-updater/issues/90.
Having option to include explicit directory entries would enable me to continue using the artifact-upload. Other options would be to allow uploading the zip directly, that way I would have the full control. But until then, I will need to upload manually again...