search

actions / upload-artifact

MIT License
3k stars 683 forks source link

[bug] v3 and v4 hang 100% uploading from macos-13 runner following CPACK_GENERATOR "DragNDrop" #573

Open howprice opened 1 month ago

howprice commented 1 month ago

What happened?

actions/upload-artifact@v4 hangs a simple CMake C++ project uploading a macOS DragNDrop package.

What did you expect to happen?

The workflow step containing actions/upload-artifact@v4 should complete very quickly and upload the artifacts as expected.

How can we reproduce it?

  1. Clone https://github.com/howprice/cleanCppProject
  2. Run https://github.com/howprice/cleanCppProject/actions/workflows/build-packages.yml manually
  3. Observe that the Upload package step never completes

Repro with v3:

  1. Edit .github/workflows/build-packages.yml and change upload-artifact@v4 to upload-artifact@v3 (remove overwrite: true to avoid build warning
  2. Run https://github.com/howprice/cleanCppProject/actions/workflows/build-packages.yml manually
  3. Observe that the Upload package step never completes

Anything else we need to know?

If the TGZ CPACK_GENERATOR is used instead, then upload-artifact behaves as expected. See e6e29f9 - Use TGZ package generator instead of DragNDrop and https://github.com/howprice/cleanCppProject/actions/runs/9362599344/job/25771653118

The DS_Store.scpt performs some UI work to set up the window and icon positions for the macOS "DragNDrop" package. Perhaps this is leaving the machine in a funny state? Are the runners headless? Should they be able to support this kind of packaging step?

I have not tried this on macos-latest (macos-14 at time of writing)

What version of the action are you using?

v4

What are your runner environments?

macos

Are you on GitHub Enterprise Server? If so, what version?

No response