search

actions / upload-artifact

MIT License
3.12k stars 702 forks source link

[bug] Symlinks are preserved by default #590

Open daskol opened 1 month ago

daskol commented 1 month ago

What happened?

Transition from v4.3.4 to v4.3.5 broke regular building pipelines because actions/upload-artifact does not derefernce symlink anymore by default and upload symlinks as is but not target files.

See "Upload StarPU libraries" job for details.

What did you expect to happen?

  1. Pipelines are expected to work as before.
  2. Symlinks are dereferenced by default.
  3. This action providesd special option/flag for (de)referencing symlinks (kind of -L/-l in common POSIX utils).

How can we reproduce it?

You can fork repo or create pull request and trigger pipeline on push event.

Anything else we need to know?

No response

What version of the action are you using?

v4.3.5 (no issue with the previous v4.3.4)

What are your runner environments?

linux

Are you on GitHub Enterprise Server? If so, what version?

No response

erick-xanadu commented 1 month ago

This also affected us. Thanks @daskol for reporting this issue.

cbaeberle commented 1 month ago

589 Seems the same issue.

cipolleschi commented 1 month ago

Hi there! Riccardo from Meta, working in the React team and taking care of the React Native build pipeline on GH. This affected us as well.

daskol commented 1 month ago

@robherley Could we revert the changes in the latest release 4.3.5 and create a new release 4.3.6? After that, we can continue working on this issue.

robherley commented 1 month ago

Hey folks, we reverted & released a new version for v4.3.6 to address the regression.

sanjacob commented 4 weeks ago

It would be really nice if this behaviour could be opt-in instead #93 #508.

Edit: after testing it seems that not all symlinks are preserved